[Openmp-commits] [PATCH] D104560: [OpenMP] Fix delete map type in ref count debug messages

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:361-362
 
 int DeviceTy::deallocTgtPtr(void *HstPtrBegin, int64_t Size, bool ForceDelete,
                             bool HasCloseModifier) {
   if (PM->RTLs.RequiresFlags & OMP_REQ_UNIFIED_SHARED_MEMORY &&
----------------
grokos wrote:
> It seems that after this patch `ForceDelete` is no longer necessary in the signature of `deallocTgtPtr`. There is only one instance where this variable is used and it's not a functional one; it is only used inside `INFO` to report whether the removal of a map entry is a forced one. I think that at this point such information is of no value since `getTgtPtrBegin` will already have printed out whether the entry is forcefully removed. Right?
Good point.  The "forcing" (the reset) doesn't happen here anymore.  All that's left is a single decrement.  I'll fix it.  Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104560/new/

https://reviews.llvm.org/D104560