[Openmp-commits] [PATCH] D104696: [AMDGPU][Libomptarget] Delete g_atl_machine global

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

That is a lot of code to throw away, very nice. Will take a closer look at the details shortly



================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/atmi_runtime.h:11
 #include "hsa.h"
+#include <hsa_ext_amd.h>
 #include <inttypes.h>
----------------
Maybe "hsa_ext_amd.h" to match the above "hsa.h". We're not consistent with this across the library, which is probably worse than using <> everywhere and worse than using "" everywhere.

I can't think of a compelling reason why the system search paths should be preferred for hsa, so would lean towards using "" everywhere


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104696/new/

https://reviews.llvm.org/D104696