[Openmp-commits] [PATCH] D104559: [OpenMP] Improve ref count debug messages

Joel E. Denny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jun 22 07:09:58 PDT 2021


jdenny updated this revision to Diff 353638.
jdenny marked 3 inline comments as done.
jdenny added a comment.

Applied grokos's suggestions: used `emplace` instead of `insert` in `DeviceTy::getOrAllocTgtPtr`.  Did the same in the existing `DeviceTy::associatePtr`.

Thanks for the review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104559/new/

https://reviews.llvm.org/D104559

Files:
  openmp/docs/design/Runtimes.rst
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/device.h
  openmp/libomptarget/src/private.h
  openmp/libomptarget/test/offloading/info.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104559.353638.patch
Type: text/x-patch
Size: 17316 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210622/b81ad7d8/attachment-0001.bin>


More information about the Openmp-commits mailing list