[Openmp-commits] [PATCH] D103545: [NFC][libomptarget] Reduce the dependency on libelf

[Vyacheslav Zakharin via Phabricator via Openmp-commits]

vzakhari added a comment.

In D103545#2826828 <https://reviews.llvm.org/D103545#2826828>, @ronlieb wrote:

> i forgot to mention that the first problem i encountered with this patch is that elf_common.cpp has difficulties finding its LLVM header files.
> i am reporting that issue.  For me, the fPIC relocatables might be a downstream issue, still looking into that one.
>
> for the header file issue, i cobbled this up
> add to end of file  openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt
> include_directories(${LIBOMPTARGET_LLVM_INCLUDE_DIRS})
>
> and added a cmake definition kind of like: 
> -DLIBOMPTARGET_LLVM_INCLUDE_DIRS=/<blah>/llvm-project/llvm/include
>
> A person more versed in CMake might have a better solution, hope so.

Please check if D104535 <https://reviews.llvm.org/D104535> fixes the header files issue.
As to the PIC issue, I do not see it.  @tianshilei1992 please provide cmake commands so that I can reproduce the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103545/new/

https://reviews.llvm.org/D103545