[Openmp-commits] [PATCH] D104474: [OpenMP] Update FAQ with additional instructions for enabling cuda offloading

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

Thanks for improving the documentation. Some comments, the documentation should be generic over specific cmake invocations / gcc versions and errors.



================
Comment at: openmp/docs/SupportAndFAQ.rst:61
+to the `LLVM_ENABLE_PROJECTS` cmake variable) since enabling the OpenMP
+runtime will build the project anyways.
 
----------------
I'd just say  something like  "If building OpenMP with `LLVM_ENABLE_RUNTIMES`, OpenMP should not be enabled as a project in `LLVM_ENABLE_PROJECTS` because it is enabled by default."


================
Comment at: openmp/docs/SupportAndFAQ.rst:223
+you would like to use an external GCC 9.1.0 build, your cmake invokation
+might look like this:
+
----------------
No need to be specific to GCC 9.1.0.


================
Comment at: openmp/docs/SupportAndFAQ.rst:230
+
+   $ cmake $llvm_project_source_dir/llvm \
+       -DLLVM_ENABLE_PROJECTS='clang;compiler-rt' \
----------------
Don't give a specific cmake invocation, we can just refer to the existing documentation for setting up CMake as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104474/new/

https://reviews.llvm.org/D104474