[Openmp-commits] [PATCH] D100997: [OpenMP] Refactor/Rework topology discovery code

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jun 15 07:52:27 PDT 2021


protze.joachim added inline comments.


================
Comment at: openmp/runtime/src/kmp_affinity.cpp:2602-2605
   unsigned prod = totals[maxIndex];
   for (index = threadIdIndex; index < maxIndex; index++) {
     prod *= maxCt[index];
   }
----------------
This patch leaves back prod unused. Is it ok to just remove the variable? I'd include this into a cleanup unused variable patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100997/new/

https://reviews.llvm.org/D100997



More information about the Openmp-commits mailing list