[Openmp-commits] [PATCH] D103606: [OpenMP][Tools] Cleanup memory pool used in Archer

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: openmp/tools/archer/ompt-tsan.cpp:366-374
+  virtual void Delete() {
+    this->Reset();
+    if (owner == DataPool<T>::ThreadDataPool)
+      owner->returnOwnData(static_cast<T *>(this));
+    else
+      owner->returnData(static_cast<T *>(this));
+  }
----------------
Hahnfeld wrote:
> Shouldn't be `virtual`, the idea of CRTP is that you can do without. `Reset` can be called after `static_cast<T *>`
Still a `virtual` class...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103606/new/

https://reviews.llvm.org/D103606