[Openmp-commits] [PATCH] D103795: [AMDGPU][Libomptarget] Remove atlc global

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

Nice, thanks. The task support was nominally deleted some time ago, iirc the init() part survived because the variable was used elsewhere as well. Good to see it go.



================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:144
 ATLMachine g_atl_machine;
 
 namespace core {
----------------
Is the type atl_context_t now unused too?


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:458
 }
 
 hsa_status_t callbackEvent(const hsa_amd_event_t *event, void *data) {
----------------
This may mean parts of g_atl_machine can be deleted too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103795/new/

https://reviews.llvm.org/D103795