[Openmp-commits] [PATCH] D103545: [NFC][libomptarget] Reduce the dependency on libelf

[Vyacheslav Zakharin via Phabricator via Openmp-commits]

vzakhari added inline comments.


================
Comment at: openmp/libomptarget/plugins/common/elf_common/elf_common.cpp:22
+#ifndef TARGET_NAME
+#define TARGET_NAME ELF Common
+#endif
----------------
JonChesterfield wrote:
> A bit surprised that GETNAME handles spaces. Have you done a debug build of this to check the DP() handling compiles cleanly?
Sure, other plugins also use TARGET_NAME with spaces.  And I did verify that LIBOMPTARGET_DEBUG output worked, e.g.:
> TARGET ELF Common --> Unknown ELF format or not an ELF image!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103545/new/

https://reviews.llvm.org/D103545