[Openmp-commits] [PATCH] D107121: [OpenMP] Fix performance regression reported in bug #51235

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked an inline comment as done.
tianshilei1992 added a comment.

In D107121#2918497 <https://reviews.llvm.org/D107121#2918497>, @protze.joachim wrote:

> Running the following command, I get below assertion from the test:
>
>   for i in $(seq 4); do numactl -C 0,1,24,25 env LD_PRELOAD=openmp/runtime/src/libomp.so openmp/runtime/test/tasking/hidden_helper_task/Output/gtid.cpp.tmp & done; wait
>   
>   gtid.cpp.tmp: llvm-project/openmp/runtime/test/tasking/hidden_helper_task/gtid.cpp:58: void assert_gtid(int) [hidden_helper_task = false]: Assertion `v == 0 || v > __kmp_hidden_helper_threads_num' failed.

I cannot reproduce your failure. Can you double check if the right `libomp.so` was being used?

  ➜ clang++ -fopenmp -L $HOME/Documents/deploy/openmp/release/lib $HOME/Documents/vscode/llvm-project/openmp/runtime/test/tasking/hidden_helper_task/gtid.cpp -o gtid
  ➜ for i in $(seq 20); do numactl -C 0,1,24,25 ./gtid & done; wait
  [2] 1304258
  [3] 1304259
  [4] 1304260
  [5] 1304261
  [6] 1304262
  [7] 1304263
  [8] 1304264
  [9] 1304265
  [10] 1304266
  [11] 1304267
  [12] 1304268
  [13] 1304269
  [14] 1304270
  [15] 1304271
  [16] 1304272
  [17] 1304273
  [18] 1304274
  [19] 1304275
  [20] 1304276
  [21] 1304277
  PASS
  [8]    1304264 done       numactl -C 0,1,24,25 ./gtid
  PASS
  [9]    1304265 done       numactl -C 0,1,24,25 ./gtid
  PASS
  PASS
  PASS
  [2]    1304258 done       numactl -C 0,1,24,25 ./gtid
  [7]    1304263 done       numactl -C 0,1,24,25 ./gtid
  [10]    1304266 done       numactl -C 0,1,24,25 ./gtid
  PASS
  [13]    1304269 done       numactl -C 0,1,24,25 ./gtid
  PASS
  [5]    1304261 done       numactl -C 0,1,24,25 ./gtid
  PASS
  PASS
  [20]  - 1304276 done       numactl -C 0,1,24,25 ./gtid
  [11]    1304267 done       numactl -C 0,1,24,25 ./gtid
  PASS
  PASS
  [17]    1304273 done       numactl -C 0,1,24,25 ./gtid
  [18]    1304274 done       numactl -C 0,1,24,25 ./gtid
  PASS
  PASS
  [19]  - 1304275 done       numactl -C 0,1,24,25 ./gtid
  PASS
  [16]  - 1304272 done       numactl -C 0,1,24,25 ./gtid
  PASS
  [21]  + 1304277 done       numactl -C 0,1,24,25 ./gtid
  [12]    1304268 done       numactl -C 0,1,24,25 ./gtid
  PASS
  PASS
  [15]  + 1304271 done       numactl -C 0,1,24,25 ./gtid
  [4]    1304260 done       numactl -C 0,1,24,25 ./gtid
  PASS
  PASS
  [6]  - 1304262 done       numactl -C 0,1,24,25 ./gtid
  [14]  + 1304270 done       numactl -C 0,1,24,25 ./gtid
  PASS
  [3]  + 1304259 done       numactl -C 0,1,24,25 ./gtid


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107121/new/

https://reviews.llvm.org/D107121