[Openmp-commits] [PATCH] D107121: [OpenMP] Fix performance regression reported in bug #51235

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked an inline comment as done.
tianshilei1992 added a comment.

In D107121#2918497 <https://reviews.llvm.org/D107121#2918497>, @protze.joachim wrote:

> Running the following command, I get below assertion from the test:
>
>   for i in $(seq 4); do numactl -C 0,1,24,25 env LD_PRELOAD=openmp/runtime/src/libomp.so openmp/runtime/test/tasking/hidden_helper_task/Output/gtid.cpp.tmp & done; wait
>   
>   gtid.cpp.tmp: llvm-project/openmp/runtime/test/tasking/hidden_helper_task/gtid.cpp:58: void assert_gtid(int) [hidden_helper_task = false]: Assertion `v == 0 || v > __kmp_hidden_helper_threads_num' failed.

Thanks. I'll see what I should do.



================
Comment at: openmp/runtime/src/kmp_tasking.cpp:2790
+        !task_team->tt.tt_hidden_helper_task_encountered) {
       // The TSC does not allow to steal victim task
       __kmp_release_bootstrap_lock(&victim_td->td.td_deque_lock);
----------------
protze.joachim wrote:
> tianshilei1992 wrote:
> > A side question here, what does "TSC" mean here?
> TSC = task stealing constraint (see OpenMP spec)
I guess it is "Task Scheduling Constraints", isn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107121/new/

https://reviews.llvm.org/D107121