[Openmp-commits] [PATCH] D106608: [OpenMP][NFC] Cleanup: silence warnings on unused variables.

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

In D106608#2916472 <https://reviews.llvm.org/D106608#2916472>, @jmellorcrummey wrote:

> i don’t understand why you find this set of changes preferable to decorating some variable declarations with __attribute__((unused))

I feel this is pretty tricky to declare a variable unused in a portable way in general. Some compilers don't accept the attribute.

Note also that the variables are actually used in some builds and not used in a other builds (debug/release, Linux/Windows, etc.), 
and conditions are different for different variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106608/new/

https://reviews.llvm.org/D106608