[Openmp-commits] [PATCH] D106870: [OpenMP] Multi architecture compilation support

Wed Jul 28 08:01:14 PDT 2021

saiislam added inline comments.

================
Comment at: openmp/libomptarget/src/rtl.cpp:306
+  std::string cmd_bin;
+  cmd_bin.assign(libomptarget_dir_name).append("/../bin/amdgpu-arch");
+  struct stat stat_buffer;
----------------
saiislam wrote:
> Call to amdgpu-arch binary is going to be replaced with call to a new library named OffloadArch. It will return current GPU name along with enabled GPU features (i.e. requirements) in a platform-independent way. As the library and its various functionalities are self-contained I decided to post it is a separate review and use amdgpu-arch here for demonstration.
> I will be posting the phab review for the library soon.
Here is the patch for the OffloadArch library: D106960

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106870/new/

https://reviews.llvm.org/D106870