[Openmp-commits] [PATCH] D106870: [OpenMP] Multi architecture compilation support

Tue Jul 27 07:01:37 PDT 2021

ye-luo added a comment.

In D106870#2907257 <https://reviews.llvm.org/D106870#2907257>, @saiislam wrote:

> In D106870#2907252 <https://reviews.llvm.org/D106870#2907252>, @ye-luo wrote:
>
>> `-fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa` seems burdensome. Could you just count how many `-Xopenmp-target=amdgcn-amd-amdhsa` there are on the comand line and then count the unique ones?
>
> I have a patch in pipeline which will eliminate need of (-fopenmp-targets, -Xopenmp-target, and -march) altogether. User will be able to compile with just "--offload-arch=gfx906" instead of using the other three flags.
> It is working in our downstream AOMP Compiler but I haven't posted a phab review yet.

That is just a convenient option and separate topic. I'm commenting on the current generic option you are fiddle with.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106870/new/

https://reviews.llvm.org/D106870