[Openmp-commits] [PATCH] D106752: [OpenMP][Tool] Introducing the `llvm-deviceinfo` tool

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM with some nits.



================
Comment at: openmp/libomptarget/plugins/cuda/CMakeLists.txt:66
   set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS} nvptx64-nvidia-cuda" PARENT_SCOPE)
+  set(LIBOMPTARGET_TESTED_PLUGINS "omptarget.rtl.cuda" PARENT_SCOPE)
 else()
----------------
what is this for? Do we have to do similar thing for AMDGCN? If no, why is it here?


================
Comment at: openmp/libomptarget/tools/CMakeLists.txt:14
+add_subdirectory(deviceinfo)
\ No newline at end of file

----------------
^^^ here


================
Comment at: openmp/libomptarget/tools/deviceinfo/CMakeLists.txt:16-29
+add_llvm_tool(llvm-omp-device-info
+  llvm-omp-device-info.cpp
+  )
+
+
+
+  llvm_update_compile_flags(llvm-omp-device-info)
----------------



================
Comment at: openmp/libomptarget/tools/deviceinfo/llvm-omp-device-info.cpp:24-26
+    if (!__tgt_print_device_info(Dev)) {
+      printf("    print_device_info not implemented\n");
+    }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106752/new/

https://reviews.llvm.org/D106752