[Openmp-commits] [PATCH] D106736: Minor Sphinx documentation generation improvements

[Scott Linder via Phabricator via Openmp-commits]

scott.linder added a comment.

LGTM, as long as @MaskRay is satisfied with the changes around `easy_install`. If MacOS still uses it but we want to discourage it on Linux then I like the current wording.



================
Comment at: llvm/docs/CMakeLists.txt:164
     # appending html/ into LLVM_INSTALL_OCAMLDOC_HTML_DIR.
-    install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/ocamldoc/html/.
+    install(DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/ocamldoc/html/"
       COMPONENT ocamldoc-html
----------------
Could the above comment be replaced with the trailing "Slash indicates contents of" comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106736/new/

https://reviews.llvm.org/D106736