[Openmp-commits] [PATCH] D106710: [OpenMP][NVPTX] Disable OpenMPOpt when building deviceRTLs

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D106710#2904241 <https://reviews.llvm.org/D106710#2904241>, @JonChesterfield wrote:

> In D106710#2904210 <https://reviews.llvm.org/D106710#2904210>, @jdoerfert wrote:
>
>> In D106710#2904091 <https://reviews.llvm.org/D106710#2904091>, @JonChesterfield wrote:
>>
>>> I'm slightly surprised that we don't have an early return in the pass when there are no kernels in the IR module since that is probably quicker than mutating the module and then mutating it back.
>>
>> We don't mutate and mutate back.
>
> I was thinking of D106707 <https://reviews.llvm.org/D106707>, haven't looked for more examples

I'm confused. What has that to do with this? In the patch we preserve symbols that have been made internal in the earlier linking step so we can use them later, all that happens after the runtime is already build and optimized and shipped.

>> We want to run on openmp-device modules without kernels to do things like globalization removal if the kernel is split across TUs, at least until we do LTO by default.
>
> OK, cool. If we have/want optimisations that run without visibility of the top level kernel then we don't want to skip the pass when there are no top level kernels.
>
> I think all is good here, I just didn't understand the commit message.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106710/new/

https://reviews.llvm.org/D106710