[Openmp-commits] [PATCH] D106710: [OpenMP][NVPTX] Disable OpenMPOpt when building deviceRTLs

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Could you clarify:

> all OpenMP optimization must start with kernels

Is the problem that the deviceRTL defines functions with names that are pattern matched from the optimisation pass, in which case this patch is definitely necessary? Analogous to building libc itself as ffreestanding.

I'm slightly surprised that we don't have an early return in the pass when there are no kernels in the IR module since that is probably quicker than mutating the module and then mutating it back. If we implemented that then we wouldn't need to special case the cmake here, but it might still be clearer to keep it explicitly disabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106710/new/

https://reviews.llvm.org/D106710