[Openmp-commits] [PATCH] D106600: [libomptarget] Build amdgpu plugin without hsa

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield reopened this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

Reopening. The patch to enable dlopen'ed HSA didn't take into account that the plugin would be initialised by libomptarget if it existed at all,  even if HSA was not present, and the error path handling for a missing HSA library was not good. Patched in D106774 <https://reviews.llvm.org/D106774>. Will reland this once that goes through CI, having now checked that behaviour is reasonable on a machine with no HSA library available at runtime (uses the host fallback, without segfaulting).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106600/new/

https://reviews.llvm.org/D106600