[Openmp-commits] [PATCH] D106774: [libomptarget][amdgpu] More robust handling of failure to init HSA

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Jul 25 15:17:58 PDT 2021


JonChesterfield added a comment.

Landed without the bounds check on device_id in `__tgt_rtl_init_device`. We might want to check that device_id is non-negative and less than the claimed number of devices, but if so, it should probably be on every external function, and possibly only in debug mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106774/new/

https://reviews.llvm.org/D106774



More information about the Openmp-commits mailing list