[Openmp-commits] [PATCH] D106774: [libomptarget][amdgpu] More robust handling of failure to init HSA
Jon Chesterfield via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Sun Jul 25 13:51:29 PDT 2021
JonChesterfield added inline comments.
Herald added a subscriber: sstefan1.
================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:977
// this is per device id init
DP("Initialize the device id: %d\n", device_id);
----------------
This paranoia may be unwarranted - calling __tgt_rtl_number_of_devices will return zero, so the library shouldn't attempt to initialize any. Will drop this sanity check if preferred.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106774/new/
https://reviews.llvm.org/D106774
More information about the Openmp-commits
mailing list