[Openmp-commits] [PATCH] D106771: [libomptarget][amdgpu] Remove call into hsa that follows failing to init hsa

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield created this revision.
JonChesterfield added a reviewer: jdoerfert.
Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
JonChesterfield requested review of this revision.
Herald added subscribers: openmp-commits, wdng.
Herald added a project: OpenMP.

[libomptarget][amdgpu] Remove call into hsa that follows failing to init hsa

The call in rtl.cpp carefully avoids calling into hsa to find out why it can't call
into hsa, but the call nested within system.cpp did not. Given the failure is reported
anyway, drop the printf. Also drop an adjacent block that looks like a merge failure.

Reported by jdoerfert


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106771

Files:
  openmp/libomptarget/plugins/amdgpu/impl/system.cpp


Index: openmp/libomptarget/plugins/amdgpu/impl/system.cpp
===================================================================
--- openmp/libomptarget/plugins/amdgpu/impl/system.cpp
+++ openmp/libomptarget/plugins/amdgpu/impl/system.cpp
@@ -356,12 +356,8 @@
   DEBUG_PRINT("Initializing HSA...");
   hsa_status_t err = hsa_init();
   if (err != HSA_STATUS_SUCCESS) {
-    printf("[%s:%d] %s failed: %s\n", __FILE__, __LINE__,
-           "Initializing the hsa runtime", get_error_string(err));
     return err;
   }
-  if (err != HSA_STATUS_SUCCESS)
-    return err;
 
   err = init_compute_and_memory();
   if (err != HSA_STATUS_SUCCESS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106771.361528.patch
Type: text/x-patch
Size: 638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210725/dd245cf4/attachment.bin>