[Openmp-commits] [PATCH] D106752: [OpenMP][Tool] Introducing the `llvm-deviceinfo` tool

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D106752#2903129 <https://reviews.llvm.org/D106752#2903129>, @jdoerfert wrote:

> Can we rename it to llvm-omp-deviceinfo everywhere please.

Since we already have `-`, what about `llvm-omp-device-info`? `deviceinfo` looks really odd.

> This looks reasonable to me, some nits. @tianshilei1992 @JonChesterfield comments?

Generally LGTM.



================
Comment at: openmp/libomptarget/src/rtl.cpp:320-324
+void RTLsTy::initAllRTLs() {
+  for (auto &R : AllRTLs) {
+    initRTLonce(R);
+  }
+}
----------------



================
Comment at: openmp/libomptarget/src/rtl.cpp:333
 
     RTLInfoTy *FoundRTL = NULL;
 
----------------



================
Comment at: openmp/libomptarget/tools/deviceinfo/llvm-deviceinfo.cpp:15
+#include "omptarget.h"
+#include <iostream>
+
----------------
jdoerfert wrote:
> 
It's a C++ file. No reason to use `stdio.h` instead of C++ header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106752/new/

https://reviews.llvm.org/D106752