[Openmp-commits] [PATCH] D106674: Runtime for Interop directive

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/private.h:117
 int __kmpc_get_target_offload(void) __attribute__((weak));
+void __kmpc_omp_wait_deps(ident_t *loc_ref, kmp_int32 gtid, kmp_int32 ndeps,
+                          kmp_depend_info_t *dep_list, kmp_int32 ndeps_noalias,
----------------
tianshilei1992 wrote:
> jdoerfert wrote:
> > tianshilei1992 wrote:
> > > If this function is not defined in `libomp`, please don't use `__kmpc`.
> > It is in libomp, this is a forward decl. All good here.
> Is it necessary to implement it in `libomp`? `interop` is for target.
eventually it is. if you don't add -fopenmp-targets you would otherwise get link errors, which sounds pretty bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106674/new/

https://reviews.llvm.org/D106674