[Openmp-commits] [PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

LGTM with one nit. @jdoerfert WDYT?



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:208
 
+__OMP_RTL(__kmpc_get_hardware_num_blocks, false, Int32, )
+__OMP_RTL(__kmpc_get_hardware_num_threads_in_block, false, Int32, )
----------------
josemonsalve2 wrote:
> tianshilei1992 wrote:
> > Probably worth a separate patch to add them.
> Do you mean just to add these 4 lines? Or should I add these lines to the front end patch D106298? 
It's better to add them to the patch where they are introduced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106033/new/

https://reviews.llvm.org/D106033