[Openmp-commits] [PATCH] D106705: [OpenMP] libomp: taskwait depend implementation fixed

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov created this revision.
AndreyChurbanov added reviewers: hbae, jlpeyton, tlwilmar, Nawrin.
AndreyChurbanov added a project: OpenMP.
Herald added subscribers: guansong, yaxunl.
AndreyChurbanov requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: openmp-commits, sstefan1.

Eliminated references from task dependency hash to node allocated on stack, thus eliminated accesses to stale memory. So the node now never freed.

Uncommented assertion which triggered when stale memory accessed.  Removed unneeded ref count increment for stack allocated node.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106705

Files:
  openmp/runtime/src/kmp_taskdeps.cpp
  openmp/runtime/src/kmp_taskdeps.h
  openmp/runtime/test/tasking/kmp_taskwait_depend_in.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106705.361327.patch
Type: text/x-patch
Size: 4721 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210723/0c15ebdc/attachment.bin>