[Openmp-commits] [PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny updated this revision to Diff 361029.
jdenny retitled this revision from "[OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)" to "[OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)".
jdenny edited the summary of this revision.
jdenny added a comment.
Herald added subscribers: dexonsmith, dang.

Applied discussed changes plus some additional cleanup:

- Renamed `hold` to `ompx_hold`.
- Internally, there's `OMPC_MAP_MODIFIER_ompx_hold`, which is named automatically based on the modifier name.  For consistency, I went with `OMP_MAP_OMPX_HOLD` and `OMP_TGT_MAPTYPE_OMPX_HOLD` instead of `OMPX_MAP_HOLD` and `OMPX_TGT_MAPTYPE_HOLD`.  For example, `grep -i ompx_hold` then finds all of these.  It's a quick search-and-replace to switch to the latter if people prefer.
- Implemented `-fopenmp-extensions`.  Without it, Clang doesn't recognize `ompx_hold`.
- Extended the diagnostic that lists expected map type modifiers to include `ompx_hold` if `-fopenmp-extensions`.
- Added phab review numbers to the `ompx_hold` entry in the OpenMP status page.
- Wordsmithed new documentation some.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106509/new/

https://reviews.llvm.org/D106509

Files:
  clang/docs/ClangCommandLineReference.rst
  clang/docs/OpenMPSupport.rst
  clang/include/clang/AST/OpenMPClause.h
  clang/include/clang/Basic/DiagnosticParseKinds.td
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Basic/LangOptions.def
  clang/include/clang/Basic/OpenMPKinds.def
  clang/include/clang/Basic/OpenMPKinds.h
  clang/include/clang/Driver/Options.td
  clang/lib/Basic/OpenMPKinds.cpp
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/lib/Parse/ParseOpenMP.cpp
  clang/lib/Sema/SemaOpenMP.cpp
  clang/test/OpenMP/driver-fopenmp-extensions.c
  clang/test/OpenMP/target_ast_print.cpp
  clang/test/OpenMP/target_data_ast_print.cpp
  clang/test/OpenMP/target_data_map_codegen_hold.cpp
  clang/test/OpenMP/target_enter_data_map_messages.c
  clang/test/OpenMP/target_exit_data_map_messages.c
  clang/test/OpenMP/target_map_codegen_hold.cpp
  clang/test/OpenMP/target_map_messages.cpp
  clang/test/OpenMP/target_parallel_for_map_messages.cpp
  clang/test/OpenMP/target_parallel_for_simd_map_messages.cpp
  clang/test/OpenMP/target_parallel_map_messages.cpp
  clang/test/OpenMP/target_simd_map_messages.cpp
  clang/test/OpenMP/target_teams_distribute_map_messages.cpp
  clang/test/OpenMP/target_teams_distribute_parallel_for_map_messages.cpp
  clang/test/OpenMP/target_teams_distribute_parallel_for_simd_map_messages.cpp
  clang/test/OpenMP/target_teams_distribute_simd_map_messages.cpp
  clang/test/OpenMP/target_teams_map_messages.cpp
  openmp/docs/index.rst
  openmp/docs/openacc/OpenMPExtensions.rst
  openmp/docs/openacc/Overview.rst

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106509.361029.patch
Type: text/x-patch
Size: 219964 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210723/fc34f554/attachment-0001.bin>