[Openmp-commits] [PATCH] D103222: Fixed bug using string stream by including missing header

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 22 11:00:40 PDT 2021


JonChesterfield added a comment.

Apologies, this change landed as part of D104923 <https://reviews.llvm.org/D104923> on June 30.

Re: clang-tidy, it doesn't run in the same environment as compilation. This is particularly noticeable for the device runtime, where clang-tidy warns about a lot of unrecognised intrinsics because it makes a wrong assumption about the target architecture. gelf.h may be a problem in practice when this builds by default, though it's also used by generic-elf-64bit so hopefully not. I'm not sure offhand what we're using from gelf.h.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103222/new/

https://reviews.llvm.org/D103222



More information about the Openmp-commits mailing list