[Openmp-commits] [PATCH] D106154: [AbstractAttributor] Fold __kmpc_parallel_level if possible

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3691
+        CallerKernelInfoAA.ParallelLevels.size() > 1)
+      SimplifiedValue = nullptr;
+    else {
----------------
jdoerfert wrote:
> 
I changed this a little bit. If `CallerKernelInfoAA.ParallelLevels` is empty, we can only tell we **currently** cannot fold it, but it doesn't mean it cannot be folded in the future. If the size is more than 1, yeah, definitely it is pessimistic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106154/new/

https://reviews.llvm.org/D106154