[Openmp-commits] [PATCH] D106509: [OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

That's strange that we need to ignore `delete` modifier, I would say that most probably there is a bug in the user's code.

> Questions:



> Clang currently doesn't support OpenMP 5.1 features unless -fopenmp-version=51. Does it make sense to have an option to enable extensions? Instead of a separate option, we could accept something like -fopenmp-version=51,hold,foo.

I would just add a new options `-fopenmp-extension` or something like this just toenable all non-standard extensions, better to keep `-fopenmp-version` as is.

> In Clang diagnostics, this patch does not add hold to the list of acceptable map type modifiers because it's an extension. Should it? If there were a command-line option to enable extensions, that would make the path clearer.

Yes, with the extensions enabled it should generate the list of all supported modifiers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106509/new/

https://reviews.llvm.org/D106509