[Openmp-commits] [PATCH] D106515: [libomptarget][amdgpu][nfc] Drop dead signal pool setup

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 22 02:08:09 PDT 2021


JonChesterfield added a comment.

It's a performance thing. I'm not sure signal creation is expensive enough to be worth caching, particularly without a thread local cache, but haven't checked.

They might be cheap to create on gfx9 and expensive on gfx8 or similar. Will need to trace through HSA to see how many operations are avoided by the cache.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106515/new/

https://reviews.llvm.org/D106515



More information about the Openmp-commits mailing list