[Openmp-commits] [PATCH] D106341: [OpenMP][FIX] Use name + type checks not only name checks for calls

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D106341#2889391 <https://reviews.llvm.org/D106341#2889391>, @tianshilei1992 wrote:

> I didn’t get the idea in the description from the code clearly. The old comparison is still address based. In what scenario that `RFI->Declaration` can be `nullptr`? The only difference might be when `CB->getCalledFunction()` and `RFI.Declarion` are both `nullptr`, which will fail the check now.

Yes. We do not set RFI.Declaration if the type doesn't match what we expect. `getCallIfRegularCall` should have always checked RFI has a declaration, now it does and that makes sure we see a call to the right function with the right type when we access the operand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106341/new/

https://reviews.llvm.org/D106341