[Openmp-commits] [PATCH] D106301: [OpenMP] Disable trap before unreachable for OpenMP device jobs

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I'm not sure about that - we could tie instcombine to -O0 or some similar proxy for debugging ve performance - but I'm practice it's fairly likely that most traps are compiler inserted so it probably works out the same.

Conditional instcombine would let us remove much of the current logic for conditionally inserting traps which seems a win for implementation complexity.

Doesn't matter much for this patch, if D106299 <https://reviews.llvm.org/D106299> lands then sure, let's switch it on for openmp GPU. If it goes the instcombine route then we don't need to toggle a switch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106301/new/

https://reviews.llvm.org/D106301