[Openmp-commits] [PATCH] D106247: [OpenMP][CMake] Fix an issue when there is space in the argument LIBOMPTARGET_LIT_ARGS

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/test/CMakeLists.txt:17
+# char into the lit command.
+string(REPLACE " " ";" LIT_ARGS ${LIBOMPTARGET_LIT_ARGS})
+
----------------
I think everything is global in cmake, so this will overwrite any other value of LIT_ARGS. If so, this probably needs to be spelled LIBOMPTARGET_LIT_ARGS_SANITIZED or similar


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106247/new/

https://reviews.llvm.org/D106247