[Openmp-commits] [PATCH] D105955: [NFC][OpenMP][Offloading] Replaced explicit parallel level computation with function `__kmpc_parallel_level`

Thu Jul 15 13:59:12 PDT 2021

tianshilei1992 added a comment.

In D105955#2880868 <https://reviews.llvm.org/D105955#2880868>, @jdoerfert wrote:

> In D105955#2880542 <https://reviews.llvm.org/D105955#2880542>, @tianshilei1992 wrote:
>
>> In D105955#2876564 <https://reviews.llvm.org/D105955#2876564>, @JonChesterfield wrote:
>>
>>> The function interface is clang internal, let's change it to take void instead of a couple of ignored arguments. That will slightly simplify clang codegen and means the pass that looks for and replaces calls to it doesn't have to consider arguments (the latter may work out of the box)
>>
>> That's probably not working because as far as I can tell, we share some code generation with host code, but for host code, the two arguments are not ignored.
>
> I don't know what you mean by not ignored. the function is device only.
>
> Drop the print and the arguments, also consider adding a new api for other parallel level lookups, we might even just reuse this one.

Oh, I misunderstood the function here. I thought it just inherits from what we have in `libomp` as it keeps the same name style starting with `__kmpc`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105955/new/

https://reviews.llvm.org/D105955