[Openmp-commits] [openmp] 405eefe - [OpenMP][NFC] Change comment style to eliminate warnings from GCC

via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 13 10:29:10 PDT 2021


Author: Peyton, Jonathan L
Date: 2021-07-13T12:27:08-05:00
New Revision: 405eefe46497bde580c28ce2d2b79f0e96f2a1d0

URL: https://github.com/llvm/llvm-project/commit/405eefe46497bde580c28ce2d2b79f0e96f2a1d0
DIFF: https://github.com/llvm/llvm-project/commit/405eefe46497bde580c28ce2d2b79f0e96f2a1d0.diff

LOG: [OpenMP][NFC] Change comment style to eliminate warnings from GCC

Standalone build for OpenMP runtime using GCC is giving -Wcomment
warnings where a backslash newline is encountered in the // style
comment. This switches the // style for /* style to silence the
warnings.

Added: 
    

Modified: 
    openmp/runtime/src/kmp_os.h

Removed: 
    


################################################################################
diff  --git a/openmp/runtime/src/kmp_os.h b/openmp/runtime/src/kmp_os.h
index 858acd9c1d7a..4437cf251892 100644
--- a/openmp/runtime/src/kmp_os.h
+++ b/openmp/runtime/src/kmp_os.h
@@ -510,8 +510,10 @@ extern kmp_uint64 __kmp_test_then_and64(volatile kmp_uint64 *p, kmp_uint64 v);
   __kmp_compare_and_store_rel8((p), (cv), (sv))
 #define KMP_COMPARE_AND_STORE_ACQ16(p, cv, sv)                                 \
   __kmp_compare_and_store_acq16((p), (cv), (sv))
-// #define KMP_COMPARE_AND_STORE_REL16(p, cv, sv)                                 \
-//   __kmp_compare_and_store_rel16((p), (cv), (sv))
+/*
+#define KMP_COMPARE_AND_STORE_REL16(p, cv, sv)                                 \
+  __kmp_compare_and_store_rel16((p), (cv), (sv))
+*/
 #define KMP_COMPARE_AND_STORE_ACQ32(p, cv, sv)                                 \
   __kmp_compare_and_store_acq32((volatile kmp_int32 *)(p), (kmp_int32)(cv),    \
                                 (kmp_int32)(sv))
@@ -578,16 +580,20 @@ inline kmp_int32 __kmp_compare_and_store_ptr(void *volatile *p, void *cv,
 }
 
 // The _RET versions return the value instead of a bool
-// #define KMP_COMPARE_AND_STORE_RET8(p, cv, sv) \
-//   _InterlockedCompareExchange8((p), (sv), (cv))
-// #define KMP_COMPARE_AND_STORE_RET16(p, cv, sv) \
-//   _InterlockedCompareExchange16((p), (sv), (cv))
+/*
+#define KMP_COMPARE_AND_STORE_RET8(p, cv, sv)                                  \
+   _InterlockedCompareExchange8((p), (sv), (cv))
+#define KMP_COMPARE_AND_STORE_RET16(p, cv, sv)                                 \
+  _InterlockedCompareExchange16((p), (sv), (cv))
+*/
 #define KMP_COMPARE_AND_STORE_RET64(p, cv, sv)                                 \
   _InterlockedCompareExchange64((volatile kmp_int64 *)(p), (kmp_int64)(sv),    \
                                 (kmp_int64)(cv))
 
-// #define KMP_XCHG_FIXED8(p, v)                                                  \
-//   _InterlockedExchange8((volatile kmp_int8 *)(p), (kmp_int8)(v));
+/*
+#define KMP_XCHG_FIXED8(p, v)                                                  \
+  _InterlockedExchange8((volatile kmp_int8 *)(p), (kmp_int8)(v));
+*/
 // #define KMP_XCHG_FIXED16(p, v) _InterlockedExchange16((p), (v));
 // #define KMP_XCHG_REAL64(p, v) __kmp_xchg_real64((p), (v)));
 


        


More information about the Openmp-commits mailing list