[Openmp-commits] [PATCH] D105121: [OpenMP] Avoid checking parent reference count in targetDataBegin

George Rokos via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 9 08:54:29 PDT 2021


grokos accepted this revision.
grokos added a comment.
This revision is now accepted and ready to land.

Thinking about it a bit more, no matter what the answer to my last question is, even the existing version of the library (without D105121 <https://reviews.llvm.org/D105121> and D104924 <https://reviews.llvm.org/D104924>) will copy the attached object to the device. So these patches result in logically equivalent behavior. @jdenny I think you can proceed with committing them as patches that simplify the code. If we need to take extra care of the corner case in the above example, then we can prepare a new patch that fixes the bug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105121/new/

https://reviews.llvm.org/D105121



More information about the Openmp-commits mailing list