[Openmp-commits] [PATCH] D105697: [libomptarget][nfc] Drop dead code in parallel_51

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

1. omp_get_level (or similar and friends) will not know we are in a parallel region now.
2. if there is a nested parallel it will not know we are in a parallel region (see my comment) and we will most likely deadlock.

(Also, I don't think "optimizing" the old runtime is worth it at this point.)



================
Comment at: openmp/libomptarget/deviceRTLs/common/src/parallel.cu:297
       (__kmpc_parallel_level(ident, global_tid) > __kmpc_is_spmd_exec_mode());
   if (!if_expr || InParallelRegion) {
     __kmpc_serialized_parallel(ident, global_tid);
----------------
^^^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105697/new/

https://reviews.llvm.org/D105697