[Openmp-commits] [PATCH] D105586: [OpenMP] Remove checkXXXX device runtime functions

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 9 01:31:20 PDT 2021


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/common/src/support.cu:47
-  // we can return immediately.
-  if (loc->reserved_2 & KMP_IDENT_SPMD_MODE)
-    return true;
----------------
Was this loc->reserved etc an optimisation before? The comments suggest deleting the reads in order to fall through to is_spmd_exec_mode would make no behaviour change, but it's hard to see how they could have been faster 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105586/new/

https://reviews.llvm.org/D105586



More information about the Openmp-commits mailing list