[Openmp-commits] [PATCH] D101977: [OpenMP] Create custom state machines for generic target regions

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:455
+  bool empty() const { return Set.empty(); }
+  int size() const { return Set.size(); }
+
----------------
tianshilei1992 wrote:
> 
size_t is probably the worst, but sure.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:461
+    BooleanState::operator^=(RHS);
+    Set.insert(RHS.Set.begin(), RHS.Set.end());
+    return *this;
----------------
tianshilei1992 wrote:
> If the state is invalid or in pessimistic state, do we want to clear the set?
no, we want the content to emit remarks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101977/new/

https://reviews.llvm.org/D101977