[Openmp-commits] [PATCH] D105403: [OpenMP][iwyu] explicitly includes `<algorithm>` in CUDA rtl.cpp

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 6 06:17:01 PDT 2021


jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:197
     // Initialize the next stream id
     std::fill(NextStreamId.begin(), NextStreamId.end(), 0);
 
----------------
JonChesterfield wrote:
> std::fill use here, looks like we could memset to avoid including algorithm
Is it worth avoiding it altogether? It's already included in the AMDGPU plugin, but it doesn't seem to be used for anything there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105403/new/

https://reviews.llvm.org/D105403



More information about the Openmp-commits mailing list