[Openmp-commits] [PATCH] D101977: [OpenMP] Create custom state machines for generic target regions

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2715
+    Function *Fn = getAnchorScope();
+    if (!OMPInfoCache.Kernels.count(Fn))
+      return;
----------------
tianshilei1992 wrote:
> Is it good to return ahead of time? In later patches we also create `AAKernelInfoFunction` for "regular" functions.
It is good to keep control flow simple. Later, as needed, we can have an `initializeKernel` and `initializeNonKernel`, for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101977/new/

https://reviews.llvm.org/D101977