[Openmp-commits] [PATCH] D105308: [OpenMP] Fix a few issues with hidden helper task

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 1 16:19:46 PDT 2021


tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:6190
 
 void __kmp_internal_end_library(int gtid_req) {
   /* if we have already cleaned up, don't try again, it wouldn't be pretty */
----------------
hbae wrote:
> tianshilei1992 wrote:
> > Just out of curiosity, why the deinitz in `__kmp_internal_end_thread` is not enough?
> When the runtime shutdown is processed by `__kmp_internal_end_library` setting `__kmp_global.g.g_done`, `__kmp_internal_end_thread` does not have a chance to finalize hidden helper.
Okay, thanks for explanation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105308/new/

https://reviews.llvm.org/D105308



More information about the Openmp-commits mailing list