[Openmp-commits] [PATCH] D105308: [OpenMP] Fix a few issues with hidden helper task

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 1 12:33:33 PDT 2021


tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LG. Thanks!



================
Comment at: openmp/runtime/src/kmp_tasking.cpp:439
 
+  auto hidden_helper = taskdata->td_flags.hidden_helper;
+
----------------
Why this needs to be done in lock? After the task is created, we never change this flag, don't we?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105308/new/

https://reviews.llvm.org/D105308



More information about the Openmp-commits mailing list