[Openmp-commits] [PATCH] D101977: [OpenMP] Create custom state machines for generic target regions

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2712
+      auto Remark = [&](OptimizationRemark OR) {
+        return OR << "Generic-mode kernel is executed without state machine "
+                     "(good)";
----------------
jhuber6 wrote:
> I think it should be clear that the optimization pass changed something. I feel just saying "Is executed" is a little ambiguous to what actually happened.
sure.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2736
+
+      auto Remark = [&](OptimizationRemark OR) {
+        return OR << "Generic-mode kernel is executed with a customized state "
----------------
jhuber6 wrote:
> Should this be an analysis remark? It pairs with the analysis remarks below.
this is the matching remark to the ones above. Why would we make one transformation and the other one analysis, this is describing the transformation as the other two are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101977/new/

https://reviews.llvm.org/D101977