[Openmp-commits] [PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

Sun Jan 31 12:01:51 PST 2021

jdoerfert added a comment.

In D95764#2532908 <https://reviews.llvm.org/D95764#2532908>, @tianshilei1992 wrote:

> In D95764#2532877 <https://reviews.llvm.org/D95764#2532877>, @jdoerfert wrote:
>
>> In D95764#2532875 <https://reviews.llvm.org/D95764#2532875>, @tianshilei1992 wrote:
>>
>>> So I suppose D95765 <https://reviews.llvm.org/D95765> can replace this patch, right?
>>
>> I think we want both. Propagating match clauses doesn't make sense to me so we should never do it.
>
> Is there any place documenting the propagation?

The standard documents that nested contexts will inherit the selectors, in a specific way. given that this is an llvm extension, we can overwrite that though. I added the documentation changes now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95764/new/

https://reviews.llvm.org/D95764