[Openmp-commits] [PATCH] D95752: [OpenMP][DeviceRTL] Extract shuffle idiom and port it to declare variant

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Jan 30 17:11:44 PST 2021


tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM. This will be the first example to merge different implementations into one file.



================
Comment at: openmp/libomptarget/deviceRTLs/common/src/data_sharing.cu:16
 #include "target_impl.h"
+#include "shuffle.h"
 
----------------
One nit: you might have `shuffle.h` before `target_impl.h` if using `clang-format`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95752/new/

https://reviews.llvm.org/D95752



More information about the Openmp-commits mailing list