[Openmp-commits] [PATCH] D95530: [libomptarget] Load images in order of registration

Simon Moll via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 28 00:33:08 PST 2021


simoll added inline comments.


================
Comment at: openmp/libomptarget/src/rtl.cpp:151-155
+    if (strcmp(Name, "libomptarget.rtl.ve.so") == 0) {
+      R.handles_library_images = true;
+    }
+
     DP("Registering RTL %s supporting %d devices!\n", R.RTLName.c_str(),
----------------
Can we make this a callback instead? Eg,

   *((void **)&R.supports_empty_images) =
        dlsym(dynlib_handle, "__tgt_rtl_supports_empty_images");


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95530/new/

https://reviews.llvm.org/D95530



More information about the Openmp-commits mailing list