[Openmp-commits] [PATCH] D95585: [OpenMP] Disabled profiling in `libomp` by default to unblock link errors

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jan 27 20:12:14 PST 2021


tianshilei1992 created this revision.
tianshilei1992 added reviewers: jdoerfert, AndreyChurbanov, kparzysz, ggeorgakoudis.
Herald added subscribers: guansong, yaxunl, mgorny.
tianshilei1992 requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1.
Herald added a project: OpenMP.

Link error occurred when time profiling in libomp is enabled by default
because `libomp` is assumed to be a C library but the dependence on
`libLLVMSupport` for profiling is a C++ library. Currently the issue blocks all
OpenMP tests in Phabricator.

This patch set a new CMake option `OPENMP_ENABLE_LIBOMP_PROFILING` to
enable/disable the feature. By default it is disabled. Note that once time
profiling is enabled for `libomp`, it becomes a C++ library.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95585

Files:
  openmp/CMakeLists.txt
  openmp/docs/design/Runtimes.rst
  openmp/runtime/CMakeLists.txt
  openmp/runtime/src/CMakeLists.txt
  openmp/runtime/src/kmp_config.h.cmake
  openmp/runtime/src/kmp_runtime.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95585.319744.patch
Type: text/x-patch
Size: 8299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210128/f604b08d/attachment-0001.bin>


More information about the Openmp-commits mailing list