[Openmp-commits] [PATCH] D95572: [libomptarget][NFC] Link plugins with threads support library due to std::call_once usage.

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jan 27 19:23:06 PST 2021


jdoerfert added a comment.

In D95572#2527082 <https://reviews.llvm.org/D95572#2527082>, @vzakhari wrote:

> In D95572#2527005 <https://reviews.llvm.org/D95572#2527005>, @grokos wrote:
>
>> I've tested the change and everything seems to work fine. So let's commit it. Thanks for the patch!
>
> Do you mean I can ignore the pre-merge checks fail?  I do not see how my changes could have affected libomp build.

looks to me like that is the C++ dependence problem we discussed this morning. I don't think this patch caused it so I would go ahead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95572/new/

https://reviews.llvm.org/D95572



More information about the Openmp-commits mailing list